inkletblot/plan9port
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mk: replace overlapping strcpy with memmove

Browse Source 
Found by ASAN.
This commit is contained in:
Russ Cox 2020-05-17 20:06:31 -04:00
parent 8cb7308f3a
commit 154140a22b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/mk/env.c
View File

@ -123,7 +123,8 @@ buildenv(Job *j, int slot)
qp = strchr(cp+1, ')'); qp = strchr(cp+1, ')');
if(qp){ if(qp){
*qp = 0; *qp = 0;
strcpy(w->s, cp+1); /* strcpy, but might overlap */
memmove(w->s, cp+1, strlen(cp+1)+1);
l = &w->next; l = &w->next;
w = w->next; w = w->next;
continue; continue;